Yair Zaslavsky has posted comments on this change.
Change subject: core : Distingushing between entity and vdsm task ids
......................................................................
Patch Set 12: (2 inline comments)
In general - good work.
Some minor comments to be fixed.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
Line 233: }
Line 234:
Line 235: protected void RemoveTaskFromDB() {
Line 236: try {
Line 237: if
(DbFacade.getInstance().getAsyncTaskDao().removeByVdsmId(getVdsmTaskId()) != 0)
{
s/removeByVdsmId/remoeByVdsmTaskId
Line 238: log.infoFormat("BaseAsyncTask::RemoveTaskFromDB:
Removed task {0} from DataBase", getVdsmTaskId());
Line 239: }
Line 240: }
Line 241:
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java
Line 92: * Removes the specified task according to its VDSM task id.
Line 93: * @param vdsmTaskId the VDSM task id.
Line 94: * @return the number of tasks deleted
Line 95: */
Line 96: int removeByVdsmId(Guid vdsmTaskId);
s/removeByVdsmId/removeByVdsmTaskId
--
To view, visit http://gerrit.ovirt.org/14075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75e35773b18e342dbe61242829ce989b1f51ee70
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
