Tal Nisan has posted comments on this change.
Change subject: core: Disallow moving SD to maintanance if there are async tasks
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 82: getReturnValue().getInternalTaskIdList().add(
Line 83: createTask(vdsReturnValue.getCreationInfo(),
Line 84: getParameters().getParentCommand(),
Line 85: VdcObjectType.Storage,
Line 86: getStorageDomainId().getValue()));
Before you ask I'll say that this was changed because in some cases the storage
domain is taken from the disk if it's not defined in the parameters, in those
cases we will get a null storage domain in the task entity ;)
Line 87: } catch (VdcBLLException e) {
Line 88: if (e.getErrorCode() !=
VdcBllErrors.ImageDoesNotExistInDomainError) {
Line 89: throw e;
Line 90: }
--
To view, visit http://gerrit.ovirt.org/14893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffb08a180be66ce74d70761ce75db96f72fe93e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
