Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: fix otopi implementation version locking handling ......................................................................
Patch Set 4: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-remove/files/simple.py Line 65: def _cleanLines(self, filename, remove_lines): Line 66: new_content = [] Line 67: with open(filename, 'r') as f: Line 68: old_content = f.read().splitlines() Line 69: for line in old_content: Done Line 70: if line not in remove_lines: Line 71: new_content.append(line) Line 72: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 73: filetransaction.FileTransaction( -- To view, visit http://gerrit.ovirt.org/14700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
