Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: fixed cpu validation
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/all-in-one/cpu.py
Line 107: hardware = util.loadModule(
Line 108:
path=osetupcons.FileLocations.AIO_HOST_DEPLOY_VDSM_PATH,
Line 109: name='hardware'
Line 110: ).Plugin(context=self.context)
Line 111: hardware._validate_virtualization()
shouldn't you take the value out of this function? and act upon?
I think you can also remove all the legacy libvirt usage... as it is redundant
now.
Line 112: except ImportError:
Line 113: self.logger.debug("Can't validate virtualization support")
Line 114: except RuntimeError as e:
Line 115: self.logger.warning(e)
Line 109: name='hardware'
Line 110: ).Plugin(context=self.context)
Line 111: hardware._validate_virtualization()
Line 112: except ImportError:
Line 113: self.logger.debug("Can't validate virtualization support")
Quotes :)
Line 114: except RuntimeError as e:
Line 115: self.logger.warning(e)
Line 116: try:
Line 117: cpu, compatible = self._getCompatibleCpuModels()
Line 110: ).Plugin(context=self.context)
Line 111: hardware._validate_virtualization()
Line 112: except ImportError:
Line 113: self.logger.debug("Can't validate virtualization support")
Line 114: except RuntimeError as e:
I think every exception...
Line 115: self.logger.warning(e)
Line 116: try:
Line 117: cpu, compatible = self._getCompatibleCpuModels()
Line 118: self.logger.debug(
--
To view, visit http://gerrit.ovirt.org/15013
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c19c1d6bf80c0d5f54105f785d97ba7b203cccc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
