Alon Bar-Lev has posted comments on this change.

Change subject: engine: [WIP] Integrate noVNC support
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 81:     </init-param>
Line 82:   </servlet>
Line 83:   <servlet-mapping>
Line 84:     <servlet-name>novnc</servlet-name>
Line 85:     <url-pattern>/novnc/*</url-pattern>
we need cooperation of einav's team for this... it is out of our scope for 
now... so we need just to update the proxy.
Line 86:   </servlet-mapping>
Line 87: 
Line 88:   <!-- SpiceX.cab -->
Line 89:   <servlet>


....................................................
File ovirt-engine.spec.in
Line 312: %package websocket-proxy
Line 313: Summary: %{product_name_short} Websocket Proxy
Line 314: Group: Virtualization/Management
Line 315: Requires: python-websockify
Line 316: Requires: m2crypto
for now we should also require ovirt-engine

I will fix this after the split.
Line 317: 
Line 318: %if %{install_systemd}
Line 319: Requires(post): systemd
Line 320: Requires(preun): systemd


--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to