Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: fixed uninstall UX
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py
Line 108: config.set(section, 'description', description)
Line 109: config.set(section, 'optional', optional)
Line 110:
Line 111: def _addFiles(section, files, description, optional):
Line 112: _addSection(section, description, optional, files)
Done
Line 113: for index, name in enumerate(sorted(set(files))):
Line 114: if os.path.exists(name):
Line 115: prefix = 'file.{index:03}'.format(index=index)
Line 116: config.set(
Line 203: _addSection(
Line 204: osetupcons.Const.FILE_GROUP_SECTION_PREFIX + section,
Line 205: group_config['description'],
Line 206: group_config['optional'],
Line 207: changes
Done
Line 208: )
Line 209: _addLines(
Line 210: osetupcons.Const.FILE_GROUP_SECTION_PREFIX + section,
Line 211: changes,
--
To view, visit http://gerrit.ovirt.org/15016
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95dddc2205a7e16dc4f4848fb6fdeab7b1e2ec2b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
