Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: branding support.
......................................................................
Patch Set 16: (5 inline comments)
Thank you so much!
I am about to have no more comments... :)
Looking real good!
Documentation should be updated, and I think that the locations should also
have a prefix so that it will be clear that they are part of an interface.
....................................................
File packaging/branding/ovirt/ovirt_common.css
Line 64: border: 1px solid #345B7A;
Line 65: }
Line 66:
Line 67: /* GWT dialogbox */
Line 68: .gwt-DialogBox .dialogTopLeft {
Is it system (gwt) names or our names? You know where I lead... why not have
prefix to these as well?
If these are system (gwt) name, I suggest a separate include file for gwt
resources.
Line 69: background: url(images/dialog/panel_edge_TL.png) no-repeat
!important;
Line 70: }
Line 71: .gwt-DialogBox .dialogTopCenter {
Line 72: background: url(images/dialog/panel_edge_T.png) !important;
....................................................
File packaging/branding/ovirt/ovirt_user_portal.css
Line 5: border-color: #719823;
Line 6: }
Line 7:
Line 8: /* UserPortalMainTab.ui.xml */
Line 9: .mainTab .obrand_activeMiddle {
I suggest to rename these with prefix so we know are also part of an
interface... .ovirt_mainTab?
Line 10: border: 1px solid #ffffff;
Line 11: background-color: #ffffff;
Line 12: font-size: 12.5px;
Line 13: color: #719823;
....................................................
File README.branding
Line 41:
Line 42: The following classes are available within the entire application:
Line 43:
Line 44: Login Popup View
Line 45: .loginPopupHeaderLogoImage
should be modified, right?
Line 46: .loginPopupHeaderCenter
Line 47: .loginPopupHeaderImage
Line 48: Simple Dialog Panel
Line 49: .dialogHeaderImage
Line 68:
Line 69: The following classes are available to the user portal:
Line 70:
Line 71: Main Tab
Line 72: .activeMiddle
these should also have prefix, such as ovirt_ for us to know these styles are
port of an interface.
Line 73: .inactiveMiddle
Line 74: .activeMiddleLink
Line 75: Header View (user portal)
Line 76: .wrapper
Line 98: MESSAGE BUNDLE FILE FORMAT
Line 99:
Line 100: The following keys are available:
Line 101:
Line 102: common.login_header_label
Should be fixed, right?
Line 103: The label displayed in the login screen header.
Line 104:
Line 105: common.main_header_label
Line 106: The label displayed on the main panel after logging in.
--
To view, visit http://gerrit.ovirt.org/13181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a8a426ce7d688d33c5ae2b70632c836843106b2
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
