Alon Bar-Lev has posted comments on this change.

Change subject: packaging: fix readme.developer - upgrade.sh
......................................................................


Patch Set 1: (3 inline comments)

You updated the wrong file.... 

Please fetch master.

There is already text for DAO.

....................................................
File README.developer
Line 53: template1=# drop database engine;
Line 54: template1=# create database engine owner engine;
Line 55: 
Line 56: 
Line 57: 
Why?
Line 58: DEVELOPMENT
Line 59: -----------
Line 60: 
Line 61: ENVIRONMENT


Line 143: The $HOME/ovirt-engine/bin/engine-cleanup-2 is also available to 
cleanup
Line 144: the environment, it is useful for application changes, less for 
packaging
Line 145: changes.
Line 146: 
Line 147: 
Only space please.
Line 148: If you would like to run the upgrade.sh script without performing 
build/setup
Line 149: Given the username is engine, the password is engine and the database 
is engine
Line 150: Please run:
Line 151: PGPASSWORD=engine ./upgrade.sh -u engine -d engine


Line 149: Given the username is engine, the password is engine and the database 
is engine
Line 150: Please run:
Line 151: PGPASSWORD=engine ./upgrade.sh -u engine -d engine
Line 152: 
Line 153: 
One space please.
Line 154: ADMINISTRATION
Line 155: 
Line 156: Most utilities and services are operational, including PKI, host 
deploy.
Line 157: 


--
To view, visit http://gerrit.ovirt.org/15037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fbd1d9bb5f10466a78ff0d7984d0db7c487e783
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to