Yair Zaslavsky has posted comments on this change. Change subject: core : Persist AsyncTask before submitting to vdsm ......................................................................
Patch Set 10: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java Line 150: return createTaskInCurrentTransaction( Line 151: taskId1, Line 152: ret1.getCreationInfo(), Line 153: VdcActionType.HibernateVm, Line 154: VdcObjectType.Storage, IMHO, no need to mention again here that VdcObjectType.Storage is associated with taskId1. You already perform the association at line 115-117, right? This is a reoccurring "pattern" in the patch. What do you think? Line 155: getStorageDomainId().getValue()); Line 156: } Line 157: }); Line 158: -- To view, visit http://gerrit.ovirt.org/14078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc5a548cb53172e6399f4334f24163dd855291ab Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
