Michael Pasternak has posted comments on this change.
Change subject: findbugs: clone does not call super clone method
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Signature.java
Line 28: public void addOptionalArgument(Object name, Object type) {
Line 29: optionalArguments.put(name,type);
Line 30: }
Line 31: public Signature clone() throws CloneNotSupportedException {
Line 32: super.clone();
not sure why this is needed, this is a POJO that does not extend any super
(besides object of course), ack'ing it just to make findbugs happy.
Line 33: Signature clonedSignature = new Signature();
Line 34: Map<Object, Object> mandatoryArguments = new HashMap<Object,
Object>();
Line 35: mandatoryArguments.putAll(getMandatoryArguments());
Line 36: Map<Object, Object> optionalArguments = new HashMap<Object,
Object>();
--
To view, visit http://gerrit.ovirt.org/15059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfe05e69c8cde480c4cba93a1ce185691d9d9316
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
