Daniel Erez has uploaded a new change for review. Change subject: webadmin: hide refresh triangle icon on sub-tabs ......................................................................
webadmin: hide refresh triangle icon on sub-tabs Refresh options/menu triangle icon is redundant for sub-tabs since isTimerDisabled == true. I.e. refresh button for sub-tabs is relevant only for manual refresh. Hence, hide refresh menu icon on sub-tabs. Affected sub-tabs: Hosts -> Network Interfaces Storage -> Images Change-Id: I5c467e94bc7a2562bac4711b6b64e5f0b6699b53 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java 2 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/15062/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java index e1bd412..5d4371b 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java @@ -177,11 +177,14 @@ private ToggleButton refreshMenuButton; + private Image separator; + private final RefreshRateOptionsMenu refreshOptionsMenu; private final Label statusLabel; private final BaseRefreshPanelCss style; + /** * Create a Panel managed by the specified {@link RefreshManager}<BR> @@ -256,17 +259,25 @@ // Create panel separator ImageResource separatorImg = RESOURCES.separator(); + separator = new Image(separatorImg); // Add refresh button and refresh options menu button HorizontalPanel panel = new HorizontalPanel(); statusLabel = new Label(); panel.add(statusLabel); panel.add(refreshButton); - panel.add(new Image(separatorImg)); + panel.add(separator); panel.add(refreshMenuButton); setWidget(panel); } + public void hideRefreshMenuButton() { + HorizontalPanel refreshPanel = (HorizontalPanel) getWidget(); + refreshPanel.remove(separator); + refreshPanel.remove(refreshMenuButton); + getElement().getStyle().setMarginRight(2, Unit.PX); + } + @Override public void setElementId(String elementId) { // Set refresh button element ID diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java index 45f5d0d..5f4151d 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java @@ -118,6 +118,9 @@ } public void showRefreshButton() { + if (getDataProvider().getModel().getIsTimerDisabled()) { + refreshPanel.hideRefreshMenuButton(); + } refreshPanel.setVisible(true); } -- To view, visit http://gerrit.ovirt.org/15062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5c467e94bc7a2562bac4711b6b64e5f0b6699b53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
