ofri masad has posted comments on this change.
Change subject: enigne:Trusted Compute Pools - Open Attestation integration
with oVirt engine proposal
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 527: final AtomicBoolean processHardwareNeededAtomic = new
AtomicBoolean();
Line 528: VDSStatus refreshReturnStatus =
Line 529:
_vdsManager.refreshCapabilities(processHardwareNeededAtomic, _vds, false);
Line 530: AttestationResultEnum trustLevel =
AttestationCacheManager.getInstance()
Line 531:
.getValueFromCache(_vds.getHostName()).getTrustLevel();
Getting NPE when cache is empty
make sure
AttestationCacheManager.getInstance().getValueFromCache(_vds.getHostName()) !=
null
Line 532: processHardwareCapsNeeded =
processHardwareNeededAtomic.get();
Line 533: refreshedCapabilities = true;
Line 534: if (refreshReturnStatus != VDSStatus.NonOperational) {
Line 535: _vdsManager.setStatus(VDSStatus.Up, _vds);
--
To view, visit http://gerrit.ovirt.org/14605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <[email protected]>
Gerrit-Reviewer: Dave Chen <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Emily Zhang <[email protected]>
Gerrit-Reviewer: Gang Wei <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
