Roy Golan has posted comments on this change.
Change subject: core: Allow to create template from scratch
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 310: return false;
Line 311: }
Line 312: }
Line 313: }
Line 314: return true;
I guess that's the only added line in this method extracting right? pls if you
can next time send a small patch with refactor like this so it would be easier
to follow.
Line 315: }
Line 316:
Line 317: protected boolean
doesStorageDomainhaveSpaceForRequest(StorageDomain storageDomain, long
spaceForRequest) {
Line 318: return validate(new
StorageDomainValidator(storageDomain).isDomainHasSpaceForRequest(spaceForRequest));
--
To view, visit http://gerrit.ovirt.org/14584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac363613af778157a50be1f7a211896d70e18952
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
