ofri masad has posted comments on this change.
Change subject: wedadmin: Trusted Compute Pools - Open Attestation integration
with oVirt engine proposal
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
Line 1085: {
Line 1086: if
(((Boolean)getClusterPolicyModel().getEnableTrustedService().getEntity()))
Line 1087: {
Line 1088: getEnableOvirtService().setEntity(true);
Line 1089: }
This is not the correct use for the "validate" method. this method is called in
order to make sure data set by the user is valid and inform the user if not. if
we change data set by the user automatically here - the user will not be aware
of the change.
instead, when the user is setting "getEnableGlusterService() = true" we can
disable selection of the Trusted-Service checkbox (and set the
getEnableTrustedService to false).
Line 1090: validService = ((Boolean)
getEnableOvirtService().getEntity())
Line 1091: || ((Boolean)
getEnableGlusterService().getEntity());
Line 1092: }
Line 1093:
--
To view, visit http://gerrit.ovirt.org/14611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59396a68708797b868bcd871abb08b3dd514f757
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Dave Chen <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Emily Zhang <[email protected]>
Gerrit-Reviewer: Gang Wei <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
