Liron Ar has uploaded a new change for review.

Change subject: core: ConnectAllHostsToLun shouldn't run within transaction
......................................................................

core: ConnectAllHostsToLun shouldn't run within transaction

The following command shouldn't run within transaction, it performs vdsm
operations only and no db updates -  Running it within transaction can
cause to timeout and leave unneeded connections.

Change-Id: I6d3bcbc8a61102439fdf732f7c969b1baf8ad8bf
Signed-off-by: Liron Aravot <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/15130/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
index 09bda2b..b6b8315 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
@@ -6,6 +6,7 @@
 import java.util.Map;
 
 import org.ovirt.engine.core.bll.Backend;
+import org.ovirt.engine.core.bll.NonTransactiveCommandAttribute;
 import org.ovirt.engine.core.common.AuditLogType;
 import org.ovirt.engine.core.common.action.ExtendSANStorageDomainParameters;
 import org.ovirt.engine.core.common.action.VdcReturnValueBase;
@@ -24,6 +25,7 @@
 import org.ovirt.engine.core.utils.log.LogFactory;
 
 @SuppressWarnings("serial")
+@NonTransactiveCommandAttribute
 public class ConnectAllHostsToLunCommand<T extends 
ExtendSANStorageDomainParameters> extends
         StorageDomainCommandBase<T> {
 


--
To view, visit http://gerrit.ovirt.org/15130
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d3bcbc8a61102439fdf732f7c969b1baf8ad8bf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to