Ravi Nori has posted comments on this change.
Change subject: core: SPMAsyncTask -> change from associatedEntities + single
type to map
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
Just minor comments
....................................................
File backend/manager/dbscripts/async_tasks_sp.sql
Line 88: LANGUAGE plpgsql;
Line 89:
Line 90:
Line 91: Create or replace FUNCTION InsertAsyncTaskEntities(
Line 92: v_task_id UUID,
Should we remove the tab
Line 93: v_entity_id UUID,
Line 94: v_entity_type varchar(128))
Line 95:
Line 96: RETURNS VOID
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java
Line 32: @Override
Line 33: public Void runInTransaction() {
Line 34:
addOrUpdateTaskInDB(asyncTask.getParameters().getDbAsyncTask());
Line 35: Map<Guid, VdcObjectType> entitiesMap =
asyncTask.getEntitiesMap();
Line 36: for (Entry<Guid, VdcObjectType> entry :
entitiesMap.entrySet()) {
Is there too many levels of nesting?
Line 37: DbFacade.getInstance()
Line 38: .getAsyncTaskDao()
Line 39:
.insertAsyncTaskEntity(asyncTask.getParameters().getDbAsyncTask().getTaskId(),
Line 40: entry.getKey(),
--
To view, visit http://gerrit.ovirt.org/14991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4136b4191a3f440b1772a76bf786acef81d6c094
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
