Daniel Erez has posted comments on this change.
Change subject: webadmin: adding custom properties to vnic dialog
......................................................................
Patch Set 9: Looks good to me, approved
(3 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
Line 213: public void edit(final VmInterfaceModel iface) {
Line 214: driver.edit(iface);
Line 215:
Line 216: hideMacWhenNotEnabled(iface);
Line 217: initCustomPropertySheet(iface);
although it's quite common to add listeners in edit method, try to move to the
presenter if easy enough.
Line 218: }
Line 219:
Line 220: private void hideMacWhenNotEnabled(VmInterfaceModel iface) {
Line 221: if (!iface.getMAC().getIsAvailable()) {
Line 238: @Override
Line 239: public void eventRaised(Event ev, Object sender,
EventArgs args) {
Line 240: String propName = ((PropertyChangedEventArgs)
args).PropertyName;
Line 241:
Line 242: // IsChangable
seems redundant..
Line 243: if ("IsChangable".equals(propName)) { //$NON-NLS-1$
Line 244: customPropertiesSheetEditor.setEnabled(false);
Line 245: }
Line 246:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
Line 261: .getSelectedItem();
Line 262:
keyValueLineModel.getKeys().setItems(getAvailbleKeys(key));
Line 263:
Line 264: keyValueLineModel.getKeys()
Line 265: .setSelectedItem(((List<String>)
keyValueLineModel.getKeys().getItems()).iterator().next());
no need to check hasNext?
Line 266:
Line 267: }
Line 268: disableEvent = false;
Line 269: }
--
To view, visit http://gerrit.ovirt.org/15020
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb066bf96ab50ab40e19c44754fc70608b48cc24
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
