Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: redesign of vm related dialogs
......................................................................
Patch Set 5: (1 inline comment)
Code looks good.
A few questions regarding the design:
1. Why do we want the static header only in VM dialog?
2. DC/Host are really relevant for all tabs?
3. Is it just a preparation for the final instance type dialog?
4. If it's indeed merely preparation, shouldn't it be merged only once we have
the full picture of the new dialog?
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
Line 21:
Line 22: .header {
Line 23: background-color: #D3D3D3;
Line 24: border-bottom: 1px solid #CED8DF;
Line 25: margin-bottom: 15px;
is it supposed to be that large?
Line 26: padding-top: 6px;
Line 27: margin-top: 4px;
Line 28: margin-right: 3px;
Line 29: display: none;
--
To view, visit http://gerrit.ovirt.org/14635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icad8098e286f821da25fac22fd0a840a42f105c9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eldan Hildesheim <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
