Oved Ourfali has posted comments on this change.
Change subject: findbugs: toString return null
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UriAuthority.java
Line 28:
Line 29: @Override
Line 30: public String toString() {
Line 31: if (!valid) {
Line 32: return "";
same here
Line 33: }
Line 34:
Line 35: String authority = new String();
Line 36: authority += host;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java
Line 36:
Line 37: @Override
Line 38: public String toString() {
Line 39: if (!valid) {
Line 40: return "";
please add the non-nls comment, as it will fail compilation.
Line 41: }
Line 42:
Line 43: String uri = new String();
Line 44: if (!scheme.isEmpty()) {
--
To view, visit http://gerrit.ovirt.org/15154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7385775b938054a5fd713c458706271b20573ad
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
