Maor Lipchuk has posted comments on this change.
Change subject: core: Remove call to super CDA
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java
Line 73: @Override
Line 74: protected boolean canDoAction() {
Line 75: boolean result = true;
Line 76: StoragePoolValidator storagePoolValidator = new
StoragePoolValidator(getStoragePool());
Line 77: if (result &&
DbFacade.getInstance().getStoragePoolDao().getByName(getStoragePool().getname())
!= null) {
you are right, thanks, will remove it.
Line 78: result = false;
Line 79:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_NAME_ALREADY_EXIST);
Line 80: } else if (!CheckStoragePoolNameLengthValid()) {
Line 81: result = false;
--
To view, visit http://gerrit.ovirt.org/15088
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33046daed409f8a0d7ad1680191ba7824087402a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
