Vered Volansky has posted comments on this change.
Change subject: core: Remove DiskImageList
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 103: VdcQueryType.GetTemplatesFromExportDomain,
tempVar);
Line 104: retVal = qretVal.getSucceeded();
Line 105: if (retVal) {
Line 106: Map<VmTemplate, List<DiskImage>> templates = (Map)
qretVal.getReturnValue();
Line 107: ArrayList<DiskImage> list = new
ArrayList<DiskImage>();
s/list/images, then use images in rest of func.
Line 108: for (VmTemplate t : templates.keySet()) {
Line 109: if (t.getId().equals(getVmTemplate().getId())) {
Line 110: list = new
ArrayList<DiskImage>(templates.get(t));
Line 111:
getVmTemplate().setInterfaces(t.getInterfaces());
--
To view, visit http://gerrit.ovirt.org/15151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic34a8038b00a4a8a05387ccb207e649adbaaed3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
