Moti Asayag has posted comments on this change.

Change subject: restapi: adding custom properties to vm interface
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 87:         model.setInterface(map(entity.getType()));
Line 88:         model.setActive(entity.isPlugged());
Line 89:         model.setPlugged(entity.isPlugged());
Line 90: 
Line 91:         if (!StringUtils.isEmpty(entity.getCustomProperties())) {
please replace !StringUtils.isEmpty with StringUtils.isNotEmpty
Line 92:             CustomProperties hooks = new CustomProperties();
Line 93:             
hooks.getCustomProperty().addAll(CustomPropertiesParser.parse(entity.getCustomProperties(),
 false));
Line 94:             model.setCustomProperties(hooks);
Line 95:         }


--
To view, visit http://gerrit.ovirt.org/15101
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f5daae4b0b2117d0cadceb2bb292fabf445c3c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to