Sahina Bose has posted comments on this change.
Change subject: gluster:Remove gluster hook from servers
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java
Line 98: List<Pair<VDS, VDSReturnValue>> pairResults =
ThreadPoolUtil.invokeAll(taskList);
Line 99: for (Pair<VDS, VDSReturnValue> pairResult : pairResults) {
Line 100:
Line 101: VDSReturnValue retValue = pairResult.getSecond();
Line 102: if (!retValue.getSucceeded() ) {
If hook is not present, vdsm layer does not throw exception on remove operation.
Line 103: errors.add(retValue.getVdsError().getMessage());
Line 104: }
Line 105: }
Line 106: } else {
Line 115: }
Line 116:
Line 117: if (getSucceeded()) {
Line 118: entity.removeMissingConflict();
Line 119: getGlusterHooksDao().remove(entity.getId());
Yes, it is. Added testcase to DAO to make sure of this.
Line 120: }
Line 121:
Line 122: }
Line 123:
--
To view, visit http://gerrit.ovirt.org/15153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic38f9edbc45a8e92b65a4a61c99b647cadb8feb3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
