Omer Frenkel has posted comments on this change. Change subject: engine: Remove Guid query parameters containers ......................................................................
Patch Set 3: > Omer - I disagree. GetXByYId clearly means you need an Id parameter class > (see, e.g., the work that Laszlo begun on b02694d) the problem is that there are some GetXByY (some examples: GetAllRelevantQuotasForStorageQuery GetAllRelevantQuotasForVdsGroupQuery GetAllVdsByStoragePoolQuery...) again, im not against, just mentioning the reason, if there is a wide agreement on this change i won't block it. -- To view, visit http://gerrit.ovirt.org/15017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I636818d92b87cdb40cb745f28b049d4bd7cabec7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
