Arik Hadas has posted comments on this change.
Change subject: core: [WIP] add memory volume to snapshot entity
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File
backend/manager/dbscripts/upgrade/03_03_0142_add_memory_volume_column_snapshots.sql
Line 1: --Add memory volume into snapshots
Line 2: SELECT fn_db_add_column('snapshots', 'memory_volume', 'character
varying(255) NOT NULL DEFAULT ''''');
I find it safer to use empty string by default instead of null - that's a
conclusion we've made from the timezone field of VM. can you explain why null
is preferable?
--
To view, visit http://gerrit.ovirt.org/14053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecda4c491fe6e207386edf2a9bf2488ec81a332a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
