Alex Lourie has posted comments on this change.
Change subject: config: added backward compatibilty
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File src/__main__.py
Line 302: def _upgrade_configs(self, configs):
Line 303: import ConfigParser
Line 304: for configfile in configs:
Line 305: cp = ConfigParser.ConfigParser()
Line 306: cp.read(configs)
shouldn't this be configfile?
Line 307: try:
Line 308: if cp.has_option('LogCollector', 'rhevm'):
Line 309: logging.info(
Line 310: 'Upgrading {filename}'.format(
--
To view, visit http://gerrit.ovirt.org/15198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I781493d9a224e412edbf1816579718de39ce0f54
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
