Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore: class does not call super.clone method ......................................................................
findbugs: ignore: class does not call super.clone method its look like a problem in findbugs because the super class is abstract and does not implement clone() method so its not possible to call super.clone() Change-Id: Ifc20e846928ae774dfd76df30468cc1364e48966 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/15205/1 diff --git a/backend/manager/modules/bll/exclude-filters.xml b/backend/manager/modules/bll/exclude-filters.xml index df64431..0d9ae09 100644 --- a/backend/manager/modules/bll/exclude-filters.xml +++ b/backend/manager/modules/bll/exclude-filters.xml @@ -56,4 +56,46 @@ <Method name="restoreSnapshotAndRemoveObsoleteSnapshots"/> <Bug code="SF"/> </Match> + + <!-- + findbugs complains that class does not call super.clone() + its super class is QuotaConsumptionParameter which is abstract + and does not implement clone() method - so it cannot be called + + findbugs reason: + CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL) + --> + <Match> + <Class name="org.ovirt.engine.core.bll.quota.QuotaVdsGroupConsumptionParameter" /> + <Method name="clone"/> + <Bug code="CN"/> + </Match> + + <!-- + findbugs complains that class does not call super.clone() + its super class is QuotaConsumptionParameter which is abstract + and does not implement clone() method - so it cannot be called + + findbugs reason: + CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL) + --> + <Match> + <Class name="org.ovirt.engine.core.bll.quota.QuotaStorageConsumptionParameter" /> + <Method name="clone"/> + <Bug code="CN"/> + </Match> + + <!-- + findbugs complains that class does not call super.clone() + its super class is QuotaConsumptionParameter which is abstract + and does not implement clone() method - so it cannot be called + + findbugs reason: + CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL) + --> + <Match> + <Class name="org.ovirt.engine.core.bll.quota.QuotaSanityParameter" /> + <Method name="clone"/> + <Bug code="CN"/> + </Match> </FindBugsFilter> -- To view, visit http://gerrit.ovirt.org/15205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc20e846928ae774dfd76df30468cc1364e48966 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
