Sahina Bose has uploaded a new change for review.

Change subject: gluster: Fixed possible NPE in update gluster hook
......................................................................

gluster: Fixed possible NPE in update gluster hook

Fixed Find Bug error with possible NPE
for vds.getName()

Change-Id: I2133a52e14527a3ace93144aaf2fdcb3f1632a24
Signed-off-by: Sahina Bose <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/15208/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
index ed67344..efd038c 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
@@ -78,7 +78,7 @@
         for (GlusterServerHook serverHook: getContentConflictServerHooks()) {
             VDS vds = getVdsDAO().get(serverHook.getServerId());
             if (vds == null || vds.getStatus() != VDSStatus.Up) {
-                setVdsName(vds.getName());
+                setVdsName(vds.getName() !=null ? vds.getName() : "NO SERVER");
                 
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP);
                 return false;
             }


--
To view, visit http://gerrit.ovirt.org/15208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2133a52e14527a3ace93144aaf2fdcb3f1632a24
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to