Allon Mureinik has posted comments on this change.
Change subject: core: [WIP] memory state handling on preview/commit/undo
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
Minor suggestion inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 143: String[] strings = snapshot.getMemoryVolume().split(",");
Line 144: Guid[] guids = new Guid[strings.length];
Line 145: for (int i=0; i<strings.length; ++i) {
Line 146: guids[i]= new Guid(strings[i]);
Line 147: }
Use GuidUtils.getGuidListFromString
Line 148: // get all vm disks in order to check post zero - if one of
the
Line 149: // disks is marked with wipe_after_delete
Line 150: boolean postZero =
Line 151:
LinqUtils.filter(getDiskDao().getAllForVm(getVm().getId()),
--
To view, visit http://gerrit.ovirt.org/14707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58a51cd0ce1cbc04f69ce71c6a7e4589da6acdd6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
