Sahina Bose has posted comments on this change.
Change subject: gluster: Added query for gluster cluster service
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterClusterServiceQueryParameters.java
Line 4:
Line 5: import
org.ovirt.engine.core.common.businessentities.gluster.ServiceType;
Line 6: import org.ovirt.engine.core.compat.Guid;
Line 7:
Line 8: public class GlusterClusterServiceQueryParameters extends
GlusterServiceQueryParameters {
Since you're no longer using GlusterServiceQueryParameters, you could refactor
this.
May want to consider calling variable clusterId instead of groupId
Line 9: private static final long serialVersionUID = -7687304241216035729L;
Line 10:
Line 11: @NotNull(message = "VALIDATION.GLUSTER.SERVICE_TYPE.NOT_NULL")
Line 12: private ServiceType serviceType;
--
To view, visit http://gerrit.ovirt.org/15241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I123e39fde8317a9227a1bd008c5afbc5dcb7691d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
