Kanagaraj M has posted comments on this change.
Change subject: gluster: Reset statusconflict flag on enable/disable
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
Line 89: VDSReturnValue retValue = pairResult.getSecond();
Line 90: if (retValue.getSucceeded() ) {
Line 91: atLeastOneSuccess = true;
Line 92: // update status in database
Line 93: addOrUpdateServerHook(serverHooks, pairResult);
you could directly call updateServerHookStatusInDb() here. Also remove the
unused serverHooks.
Line 94: } else {
Line 95: errors.add(retValue.getVdsError().getMessage());
Line 96: }
Line 97: }
--
To view, visit http://gerrit.ovirt.org/15242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9913900175e0f5be33bb1ec45b882e770a09fde4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
