Oved Ourfali has posted comments on this change.
Change subject: findbugs: inefficient use of String constructor
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java
Line 24: private UriAuthority authority;
Line 25: private String path;
Line 26:
Line 27: public Uri(String uri) {
Line 28: MatchResult matcher = PATTERN_URI.exec(uri == null ? "" : uri);
don't you need a non-nls comment on these lines?
Line 29: valid = matcher != null;
Line 30: if (valid) {
Line 31: setScheme(matcher.getGroup(1));
Line 32: setAuthority(new UriAuthority(matcher.getGroup(2)));
--
To view, visit http://gerrit.ovirt.org/15277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96b98c508f2ca60daed60be6ec29db35c2016bb3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
