Shahar Havivi has uploaded a new change for review. Change subject: Use ThreadLocalRandom instead of Random ......................................................................
Use ThreadLocalRandom instead of Random Which is a single object and more robust in multithreaded environment This is a fix to http://gerrit.ovirt.org/#/c/15271/ Change-Id: Ia35ac7e44647e28bd6799da7b7885ee2aa59869d Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/79/15279/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java index 034e91b..90f76d3 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java @@ -19,8 +19,8 @@ import java.util.Date; import java.util.HashMap; import java.util.Map; -import java.util.Random; import java.util.TimeZone; +import java.util.concurrent.ThreadLocalRandom; import org.apache.commons.codec.binary.Base64; import org.ovirt.engine.core.common.config.Config; @@ -31,8 +31,7 @@ PrivateKey key; private final int lifetime; - protected Random random = new Random(); - + /** * Creates a TicketUtils instance for */ @@ -83,7 +82,7 @@ * Add signed fields */ byte[] random = new byte[8]; - this.random.nextBytes(random); + ThreadLocalRandom.current().nextBytes(random); map.put("salt", base64.encodeToString(random)); SimpleDateFormat df = new SimpleDateFormat("yyyyMMddHHmmss"); -- To view, visit http://gerrit.ovirt.org/15279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia35ac7e44647e28bd6799da7b7885ee2aa59869d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
