Yair Zaslavsky has posted comments on this change.
Change subject: core: Power Management failed if no proxy ...
......................................................................
Patch Set 2: (2 inline comments)
Minor comments.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
Line 60: proxyHostId = NO_VDS;
Line 61: VDS proxyHost = null;
Line 62: boolean proxyFound = false;
Line 63: // get PM Proxy preferences or use defaults if not defined
Line 64: String pmProxyPreferences =
(org.apache.commons.lang.StringUtils.isEmpty(_vds.getPmProxyPreferences()))
Please remove the full class name by introducing "import
org.apache.commons.lang.StringUtils".
Line 65: ?
Line 66: Config.<String>
GetValue(ConfigValues.FenceProxyDefaultPreferences)
Line 67: : _vds.getPmProxyPreferences();
Line 68: String[] pmProxyOPtions = pmProxyPreferences.split(",");
....................................................
Commit Message
Line 9: core: Power Management failed if no proxy preferences is defined for
the host
Line 10:
Line 11: Power Management failed if no pm_proxy preferences is defined for the
Line 12: host.
Line 13: The pm_proxy_preferences is a per-host field in vds_static that defined
s/defined/defines
Line 14: how to look for a proxy host. (cluster then DC or vice versa)
Line 15: In case that pm_proxy preference is not defined , it should be taken
Line 16: from the FenceProxyDefaultPreferences configuration value which is
Line 17: defaulted to "cluster,dc"
--
To view, visit http://gerrit.ovirt.org/15274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b96b115dc586e6ebbdacd44e0a034e91609841
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
