Moti Asayag has posted comments on this change.
Change subject: engine: Added query for external networks on provider
......................................................................
Patch Set 22: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/GetAllExternalNetworksOnProviderQuery.java
Line 12: }
Line 13:
Line 14: @Override
Line 15: protected void executeQueryCommand() {
Line 16: Provider provider =
getDbFacade().getProviderDao().get(getParameters().getId());
shouldn't provider be validated for existence prior to accessing it?
Line 17: NetworkProviderProxy client =
getProviderProxyFactory().create(provider);
Line 18: getQueryReturnValue().setReturnValue(client.getAll());
Line 19: }
Line 20:
--
To view, visit http://gerrit.ovirt.org/10789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2954addacfea09e0b44bf2770f80be92f75b6db5
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
