Allon Mureinik has posted comments on this change.
Change subject: core: fix typos in CanDoActionTestUtils
......................................................................
Patch Set 2: (1 inline comment)
For some reason I dropped my comment on line 32 - please see inline.
Two of the three proposed changes are wrong.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java
Line 28: boolean canDoAction = command.canDoAction();
Line 29: List<String> canDoActionMessages =
command.getReturnValue().getCanDoActionMessages();
Line 30:
Line 31: assertFalse("Command's canDoAction expected to fail, but
succeeded", canDoAction);
Line 32: assertTrue(MessageFormat.format("canDoAction messages doesn't
contain expected message: {0}, messages are: {1}",
arg, seem to have lost a comment here. gerrit foobar. Sorry.
doubling the quote ('') is MessageFormat's way to escape a quote mark (').
Without it, the message comes out "canDoAction messages doesn't contain
expected message.."
Hence, the change to this line is wrong.
Line 33: message.name(),
Line 34: canDoActionMessages),
Line 35: canDoActionMessages.contains(message.name()));
Line 36:
--
To view, visit http://gerrit.ovirt.org/15270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic85f211c57df6febd6f79c5127a6eb97d38d2710
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
