Tomas Jelinek has posted comments on this change.
Change subject: core: [WIP] Use OS repository intead of VmOsType
......................................................................
Patch Set 8: (1 inline comment)
Why have you removed the generic param from INewAsyncCallback? It was already
there and looked awesome.
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java
Line 30: if (osName.startsWith(wordPart)) {
Line 31: list.add(osName);
Line 32: }
Line 33: }
Line 34: return list.toArray(new String[]{});
well, I would prefer list.toArray(new String[list.size()]) - you save one
instance :)
Line 35: }
Line 36:
Line 37: @Override
Line 38: public boolean validate(String text) {
--
To view, visit http://gerrit.ovirt.org/15078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I168225f20d567910cba861be75be87136926589f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
