Shahar Havivi has uploaded a new change for review. Change subject: findbugs: Transient field is not set by deserialization ......................................................................
findbugs: Transient field is not set by deserialization findbugs reason: Se: Transient field that isn't set by deserialization. (SE_TRANSIENT_FIELD_NOT_RESTORED) Change-Id: I7bb8a32a3d458f40ca8beba7c0115927c1f4bd42 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/29/15329/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java index 2d9f032..37194c2 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java @@ -1,5 +1,6 @@ package org.ovirt.engine.core.common.action; +import java.io.IOException; import java.util.List; import javax.validation.constraints.Pattern; @@ -64,6 +65,10 @@ setParentCommand(VdcActionType.Unknown); } + private void readObject(java.io.ObjectInputStream in) throws IOException, ClassNotFoundException { + executionReason = CommandExecutionReason.REGULAR_FLOW; + } + public Guid getCommandId() { return commandId; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java index 12452da..252b468 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java @@ -1,8 +1,10 @@ package org.ovirt.engine.core.common.businessentities; +import java.io.IOException; import java.io.Serializable; import org.ovirt.engine.core.common.action.VdcActionType; +import org.ovirt.engine.core.common.action.VdcActionParametersBase.CommandExecutionReason; import org.ovirt.engine.core.common.utils.ObjectUtils; import org.ovirt.engine.core.compat.Version; @@ -65,6 +67,10 @@ public void setNullValue(boolean nullValue) { this.nullValue = nullValue; } + + private void readObject(java.io.ObjectInputStream in) throws IOException, ClassNotFoundException { + this.nullValue = false; + } @Override public int hashCode() { -- To view, visit http://gerrit.ovirt.org/15329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7bb8a32a3d458f40ca8beba7c0115927c1f4bd42 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
