Sahina Bose has posted comments on this change.
Change subject: gluster: VDS comand for start/stop of services
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment inline
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
Line 763: @DefaultStringValue("Failed to remove hook")
Line 764: String GlusterHookRemoveFailed();
Line 765:
Line 766: @DefaultStringValue("Manage (start/stop/restart) service failed")
Line 767: String GlusterServicesManageFailed();
You could remove this as we use GlusterServiceManageFailed
Line 768:
Line 769: @DefaultStringValue("Gluster service operation failed")
Line 770: String GlusterServicesFailed();
Line 771:
--
To view, visit http://gerrit.ovirt.org/15076
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53ffc535653b1632b598759d47d9cfc7d914269b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
