Yair Zaslavsky has posted comments on this change.

Change subject: core: Adds custom properties to VmDevice
......................................................................


Patch Set 13: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
Line 50:                 .addValue("is_managed", entity.getIsManaged())
Line 51:                 .addValue("is_plugged", entity.getIsPlugged())
Line 52:                 .addValue("is_readonly", entity.getIsReadOnly())
Line 53:                 .addValue("alias", entity.getAlias())
Line 54:                 .addValue("custom_properties",
Sure, I'm in favor.
Martin?
Line 55:                         entity.getCustomProperties() == null ? null : 
SerializationFactory
Line 56:                                 .getSerializer()
Line 57:                                 
.serialize(entity.getCustomProperties()));
Line 58:     }


--
To view, visit http://gerrit.ovirt.org/14814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to