Omer Frenkel has posted comments on this change.
Change subject: add Image and Instance type interfaces
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageType.java
Line 1: package org.ovirt.engine.core.common.businessentities;
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public interface ImageType extends BusinessEntity<Guid> {
Done
Line 6:
Line 7: String getName();
Line 8: void setName(String value);
Line 9:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java
Line 42:
Line 43: int getPriority();
Line 44: void setPriority(int value);
Line 45:
Line 46: // missing:
right, added doc for devices, added TODO for predefined props, as this should
be handled later (not implemented in template so problematic to add it right
now, and not worth blocking this patch for it)
Line 47: //userdefined_properties
Line 48: //predefined_properties
Line 49: //min_allocated_mem
Line 50: //smart card device
--
To view, visit http://gerrit.ovirt.org/12279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ef6393038588383a6f110d9743e4412ee97f75
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
