Arik Hadas has posted comments on this change.
Change subject: core: restore memory from snapshot on run vm
......................................................................
Patch Set 15: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
Line 92: vm.getVdsGroupCpuFlagsData());
Line 93: }
Line 94: createInfo.put(VdsProperties.niceLevel,
Line 95: String.valueOf(vm.getNiceLevel()));
Line 96: if (!StringUtils.isEmpty(vm.getHibernationVolHandle())) {
I think we're covered:
- if the VM is suspended, we took the memory volume and we still do
- if the VM is not suspended, at RunVmCommand#initCreateVmParams we take the
memory volume from the active snapshot anyway so if there's no memory, the
memory volume will be empty
Line 97: createInfo.put(VdsProperties.hiberVolHandle,
Line 98: vm.getHibernationVolHandle());
Line 99: }
Line 100: String keyboardLayout = vm.getVncKeyboardLayout(); // if set
per VM use that value
--
To view, visit http://gerrit.ovirt.org/14860
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id382ff479827af96fc529b57ec0ea1b0b7d21818
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
