Shahar Havivi has uploaded a new change for review. Change subject: findbugs: resultSet is not close after use ......................................................................
findbugs: resultSet is not close after use findbugs reason: OBL: Method may fail to clean up stream or resource (OBL_UNSATISFIED_OBLIGATION) Change-Id: I8c00d797b737291e3aac8cea1817dfddc04f39a2 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/15/15415/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java index 7706e6c..6ef789c 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java @@ -82,12 +82,13 @@ Connection connection = null; PreparedStatement prepareStatement = null; ConfigKey ckReturn = null; + ResultSet resultSet = null; try { connection = ds.getConnection(); prepareStatement = connection.prepareStatement(selectSql); prepareStatement.setString(1, key.getKey()); prepareStatement.setString(2, key.getVersion()); - ResultSet resultSet = prepareStatement.executeQuery(); + resultSet = prepareStatement.executeQuery(); resultSet.next(); try { String value = resultSet.getString(valueColumn); @@ -96,6 +97,9 @@ throw new SQLException("Failed to fetch value of " + key.getKey() + " with version " + key.getVersion() + " from DB. " + e.getMessage()); } } finally { + if (resultSet != null) { + resultSet.close(); + } if (prepareStatement != null) { prepareStatement.close(); } @@ -110,12 +114,13 @@ public List<ConfigKey> getKeysForName(String name) throws SQLException { Connection connection = null; PreparedStatement prepareStatement = null; + ResultSet resultSet = null; List<ConfigKey> keys = new ArrayList<ConfigKey>(); try { connection = ds.getConnection(); prepareStatement = connection.prepareStatement(selectKeysForNameSql); prepareStatement.setString(1, name); - ResultSet resultSet = prepareStatement.executeQuery(); + resultSet = prepareStatement.executeQuery(); while (resultSet.next()) { try { keys.add(ConfigKeyFactory.getInstance().fromResultSet(resultSet)); @@ -125,6 +130,9 @@ } } } finally { + if (resultSet != null) { + resultSet.close(); + } if (prepareStatement != null) { prepareStatement.close(); } -- To view, visit http://gerrit.ovirt.org/15415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8c00d797b737291e3aac8cea1817dfddc04f39a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
