Einav Cohen has posted comments on this change.
Change subject: engine: add comment field to DataCenter [1]
......................................................................
Patch Set 8:
> To Einav: Erez said it looks OK but he wishes to wait until all the parches
> are ready.
from Daniel's comment [1] I got the second part ("he wishes to wait until all
the parches are ready"), however I haven't got the first part ("it looks OK")
as he hasn't granted "+1" and hasn't mentioned anything about being OK with it
in his comment.
> I personally disagree and would like to push the patches as soon as the are
> ready and reviewed because they are independent
I somewhat understand Daniel's concern from the ux perspective, however it is
not too bad - the different business entities already differ significantly from
one another fields-wise anyway; IMO it doesn't really matter if one additional
different/common field is introduced now/later to one/all business entity(ies).
So I agree with Noam that pushing these changes gradually (rather than all at
once) makes sense, as they are independent.
@Derez - any chance that you can give "+1" on this change, if you are OK with
the code (assuming that you don't strongly object to introducing the new field
only to the DC business entity at this stage)?
[1] "I think it's preferable to merge along with the other business entities
(i.e. only when the work is completed on all main tabs)."
--
To view, visit http://gerrit.ovirt.org/14878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
