Sharad Mishra has posted comments on this change.
Change subject: core: wip: Introducing ImportVmFromConfigurationCommand
......................................................................
Patch Set 2: (1 inline comment)
looks good in the first pass
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
Line 47: }
Line 48:
Line 49: @Override
Line 50: public boolean canDoAction() {
Line 51: if (getVmFromConfiguration() == null) {
Can we store the VM locally from getVmFromConfiguration and use that local
copy in line #67?
Line 52: return
failCanDoAction(VdcBllMessages.VM_CANNOT_IMPORT_FROM_CONFIGURATION_ERROR_PARSING);
Line 53: }
Line 54:
Line 55: if (!acquireLockInternal()) {
--
To view, visit http://gerrit.ovirt.org/15419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I217474e2f6b302140d72b662dbe1f8ef90d05c40
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
