Moti Asayag has posted comments on this change.
Change subject: findbugs: Suspicious reference comparison of Boolean values
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
Line 164: @Override
Line 165: public void postProcess(ServerResponse response) {
Line 166: HttpSession httpSession = getCurrentSession(false);
Line 167: if (!current.get(MetaData.class).hasKey("async") ||
Line 168: (!((Boolean)
current.get(MetaData.class).get("async")).equals(Boolean.TRUE))) {
I'd reverse the operands as I'm not sure if
current.get(MetaData.class).get("async") might return null or not.
e.g.
!(Boolean.TRUE.equals((Boolean) current.get(MetaData.class).get("async")))
Sorry for raising this just now and not onmy previous review.
Line 169: VdcUser user = current.get(VdcUser.class);
Line 170: if (user != null) {
Line 171: if (!persistentSession) {
Line 172: backend.Logoff(
--
To view, visit http://gerrit.ovirt.org/15325
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I210767bb1e273caa421bf3da1b1608a7facb6621
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
