Yair Zaslavsky has posted comments on this change.
Change subject: core: Change CreateAllSnapshotsFromVmCommand to persist all
placeholders
......................................................................
Patch Set 24: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
Line 19: @InternalCommandAttribute
Line 20: @NonTransactiveCommandAttribute(forceCompensation=true)
Line 21: public class AddImageFromScratchCommand<T extends
AddImageFromScratchParameters> extends CreateSnapshotCommand<T> {
Line 22:
Line 23: protected static final String TASK_KEY = "CreateImage";
Ravi, maybe in case of a single task, we can have like
DEFAULT_TASK_KEY at command base, and have a version of
persistAsyncTaskPlaceHolder which uses by default that key?
Line 24:
Line 25: public AddImageFromScratchCommand(T parameters) {
Line 26: super(parameters);
Line 27: setVmId(getParameters().getMasterVmId());
--
To view, visit http://gerrit.ovirt.org/14841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f9524667922b99bfe47fc3659f7969efef72996
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
