ofri masad has posted comments on this change.
Change subject: engine:Trusted Compute Pools - Open Attestation integration
with oVirt engine proposal
......................................................................
Patch Set 10: (6 inline comments)
The current patch does not compile
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java
Line 62: valueList = AttestationService.getInstance().attestHosts(
Line 63: curVdsNames);
Line 64: addToAttestationMap(valueList);
Line 65: i++;
Line 66: }
I think the reason we added the 'while' loop was to cut the list to few small
lists with size=attestationFirstStageSize
using the 'i' param and the 'secondStageFlag' is unclear to me - but the result
is we get only two sublists.
Line 67: }
Line 68:
Line 69: public void initVds() {
Line 70: for (VDS vds : vdss) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1334: DelayResetPerVmInSeconds(504),
Line 1335:
Line 1336: @TypeConverterAttribute(Boolean.class)
Line 1337: @DefaultValueAttribute("true")
Line 1338: SecureConnectionWithOATServers(426),
number 426 is already in use - please change this on rebase
Line 1339:
Line 1340: @TypeConverterAttribute(String.class)
Line 1341: @DefaultValueAttribute("AttestationService/resources/PollHosts")
Line 1342: PollUri(427),
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java
Line 28: private static final String HEADER_VTIME = "vtime";
Line 29: private static final String CONTENT_TYPE = "application/json";
Line 30: private static final AttestationService instance = new
AttestationService();
Line 31: private static final Log log =
LogFactory.getLog(AttestationService.class);
Line 32: private final HashMap<String, AttestationResultEnum>
attestationValues = new HashMap<String, AttestationResultEnum>();
Please map GUID-->AttestationResultEnum
remember that this map can cover few LAN, so we could get the same host name
from different LAN
Line 33:
Line 34: public static HttpClient getClient() {
Line 35: HttpClient httpClient = new HttpClient();
Line 36: if (Config
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 406: "Succeeded to refreshCapabilities for host
{0} , new status will be {1} ",
Line 407: getVdsId(),
Line 408: newStatus);
Line 409: }
Line 410: if (vds.getTrustedService()){
Compilation error: method getTrustedService() does not exist
Line 411: List <String> hosts = new ArrayList<String> ();
Line 412: hosts.add(vds.getHostName());
Line 413: AttestationValue value =
AttestationService.getInstance().attestHosts(hosts).get(0);
Line 414:
AttestationCacheManager.getInstance().updateCache(value);
Line 410: if (vds.getTrustedService()){
Line 411: List <String> hosts = new ArrayList<String> ();
Line 412: hosts.add(vds.getHostName());
Line 413: AttestationValue value =
AttestationService.getInstance().attestHosts(hosts).get(0);
Line 414:
AttestationCacheManager.getInstance().updateCache(value);
Compilation error: AttestationCacheManager does not exist
Line 415: if (value.getTrustLevel() ==
AttestationResultEnum.TRUSTED) {
Line 416: vds.setStatus(VDSStatus.Up);
Line 417: } else {
Line 418: vds.setStatus(VDSStatus.NonOperational);
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 524: }
Line 525: } else {
Line 526: // refresh dynamic data
Line 527: final AtomicBoolean processHardwareNeededAtomic = new
AtomicBoolean();
Line 528: boolean checkOtherParams = _vds.getTrustedService()?
false: true;
Compilation error: getTrustedService() does not exist
Line 529: if (_vds.getTrustedService()){
Line 530: AttestationResultEnum trustLevel =
AttestationService.getInstance().getAttestationValues().remove(_vds.getHostName());
Line 531: if (trustLevel != null && trustLevel !=
AttestationResultEnum.TRUSTED){
Line 532: _vds.setStatus(VDSStatus.NonOperational);
--
To view, visit http://gerrit.ovirt.org/14605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <[email protected]>
Gerrit-Reviewer: Dave Chen <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Emily Zhang <[email protected]>
Gerrit-Reviewer: Gang Wei <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
