Sahina Bose has posted comments on this change.
Change subject: gluster:Use uid check while sync from CLI
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 198: if
(GlusterFeatureSupported.glusterHostUuidSupported(server.getVdsGroupCompatibilityVersion()))
{
Line 199: // compare gluster host uuid stored in server with the
ones fetched from list
Line 200: GlusterServer glusterServer =
getGlusterServerDao().getByServerId(server.getId());
Line 201: for (GlusterServerInfo fetchedServer : fetchedServers) {
Line 202: if
(fetchedServer.getUuid().equals(glusterServer.getGlusterServerUuid())) {
As per http://gerrit.ovirt.org/#/c/13785/, gluster host UUID should never be
null.
Line 203: return false;
Line 204: }
Line 205: }
Line 206: return true;
--
To view, visit http://gerrit.ovirt.org/15437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74b47bde915bb0736bce3826e371d8583e1cc6b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
