Vinzenz Feenstra has posted comments on this change.
Change subject: agent: Use python 2.4 syntax in GuestAgentLinux2
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File ovirt-guest-agent/GuestAgentLinux2.py
Line 253: except:
Line 254: logging.exception("Error retrieving disks
usages.")
Line 255: mounts.close()
Line 256: except Exception:
Line 257: logging.execption("Error during reading mounted devices")
Well it won't fail until there's an exception, which did not happen to me so
far ;)
But good catch!
Line 258: if mounts:
Line 259: mounts.close()
Line 260:
Line 261: return usages
--
To view, visit http://gerrit.ovirt.org/14545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c570c2cca4a71f15173601aaed27522e01e895
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
